Skip to content

Conversation

@gusinacio
Copy link
Contributor

No description provided.

@gusinacio gusinacio changed the title Gusinacio/refactor actor system refactor: actor system for tap-agent Mar 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Pull Request Test Coverage Report for Build 8652297458

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1074 of 1250 (85.92%) changed or added relevant lines in 9 files are covered.
  • 66 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+4.2%) to 67.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/main.rs 0 16 0.0%
tap-agent/src/agent/sender_account.rs 265 285 92.98%
tap-agent/src/agent/sender_accounts_manager.rs 351 378 92.86%
tap-agent/src/agent.rs 0 52 0.0%
tap-agent/src/agent/sender_allocation.rs 358 419 85.44%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/tap/context/receipt.rs 1 88.33%
tap-agent/src/agent.rs 1 0.0%
common/src/escrow_accounts.rs 1 79.08%
common/src/indexer_service/http/indexer_service.rs 63 0.0%
Totals Coverage Status
Change from base Build 8286736940: 4.2%
Covered Lines: 3236
Relevant Lines: 4761

💛 - Coveralls

@gusinacio gusinacio force-pushed the gusinacio/refactor-actor-system branch 2 times, most recently from 0f075b5 to 37ac6ec Compare April 3, 2024 01:31
@gusinacio gusinacio force-pushed the gusinacio/refactor-actor-system branch 3 times, most recently from 5732da8 to c237d97 Compare April 11, 2024 17:16
@gusinacio gusinacio marked this pull request as ready for review April 11, 2024 17:24
@gusinacio gusinacio requested a review from aasseman April 11, 2024 19:38
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/refactor-actor-system branch from 6927b73 to c27f7a2 Compare April 11, 2024 22:13
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/refactor-actor-system branch from 9672c35 to b85c1f0 Compare April 12, 2024 00:58
@gusinacio gusinacio force-pushed the gusinacio/refactor-actor-system branch from 11f0d97 to f15b6f7 Compare April 12, 2024 01:32
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/refactor-actor-system branch from a499f63 to 7effcb5 Compare April 14, 2024 21:16
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note that for 7effcb5, fixing a test still counts as "test", not "fix". Logic being that messing around with the tests doesn't change the code that gets shipped, so it shouldn't result in a version bump.
Doesn't matter too much here though since we're gonna squash.

@aasseman aasseman merged commit f77ca61 into main Apr 15, 2024
@aasseman aasseman deleted the gusinacio/refactor-actor-system branch April 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants