Skip to content

Conversation

@Maikol
Copy link
Member

@Maikol Maikol commented Dec 12, 2025

No description provided.

@Maikol Maikol force-pushed the mde/ci-release-tags branch from f0f8032 to 369f829 Compare December 15, 2025 22:05
@Maikol Maikol force-pushed the mde/ci-release-tags branch from 369f829 to 37ae754 Compare December 15, 2025 22:22
@MoonBoi9001
Copy link
Member

Looks good — fixes the CI branch trigger and adds proper semver tagging for releases.

A few optional improvements to consider (now or in a follow-up):

  • Bump the other action versionsdocker/login-action@v1 and docker/build-push-action@v2 are a few majors behind while metadata-action is now at v5
  • Add workflow_dispatch — lets you manually trigger builds from the UI without pushing
  • Add explicit permissions blockcontents: read + packages: write follows least-privilege

None are blockers, just polish.


Review by @MoonBoi9001 with @claude

on:
push:
branches: [master]
branches: [main]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be tempted to remove explicit branches, so that it happens on all branches.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to trigger the workflow for all commits on any branch. Current workflow runs on pull request opened and on main branch after a PR is merged, I believe this should cover all use cases.

@Maikol Maikol merged commit a49c878 into main Dec 16, 2025
3 checks passed
@Maikol Maikol deleted the mde/ci-release-tags branch December 16, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants