Skip to content

Grammar fixes in README.md documentation.#23

Merged
mcelicalderon merged 4 commits intographql-devise:masterfrom
aarona:master
Oct 16, 2019
Merged

Grammar fixes in README.md documentation.#23
mcelicalderon merged 4 commits intographql-devise:masterfrom
aarona:master

Conversation

@aarona
Copy link
Copy Markdown
Contributor

@aarona aarona commented Oct 16, 2019

No description provided.

@mcelicalderon
Copy link
Copy Markdown
Member

mcelicalderon commented Oct 16, 2019

Why did you open this one and closed #20 ? Doing this makes reviewing harder as I have to review this one from scratch. Not a big deal on this one, but might be a problem for bigger PRs. Try to make any change necessary on the same PR next time.

@aarona
Copy link
Copy Markdown
Contributor Author

aarona commented Oct 16, 2019

Sorry about that. Still new with contributing to github projects. Please be patient with me! :-)

Copy link
Copy Markdown
Member

@mcelicalderon mcelicalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mcelicalderon mcelicalderon merged commit fc6b0d5 into graphql-devise:master Oct 16, 2019
@mcelicalderon mcelicalderon added the documentation Improvements or additions to documentation label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants