GraphQLHttpClient sends request twice when APQ is enabled

[cookj4]

I am trying to set up my queries to use APQ, but the request is always being sent twice. I see why that is happening in the code here, but I must be missing something. The way I am reading this, every code path that uses APQ assumes the request failed and resends it. It seems like the else here is not needed (or alternatively should be an else if), as there is no indication that the request did not succeed. Any help understanding this would be much appreciated.

[rose-a]

It works like this:

• L102 - 109: If APQ enabled, generate APQ request extensions (hash and version), save the query string for line 122/130 and then set the query string on the request to null
• L111: Send the request without the actual request string, just the hash. So if the query is already persisted, the server knows from the hash which query that is and answers the query.
• L115: If the request has failed and the error contains the string "PersistedQueryNotFound", this means that the server supports APQ, but has not seen a query with this hash yet. L122 then sends the request again including the actual query string, so the server can store it for next time.
• L124-130: on any other error in the response, the response is passed through the GraphQLHttpClientOptions.DisableAPQ delegate, which decides if the response means the server doesn't support APQ. If so, APQ gets disabled completely for the current session (as long as the GraphQLHttpClient lives) to avoid the overhea of always trying to use APQ on a server not supporting it. It then resends the request including the actual query string. I guess this could be improved in that requests are only resent in L130 if APQDisabledForSession is true, and not on every error occurring with APQ enabled.