Adding initialization headers to a WebSocket GraphQL client #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Oct 5, 2020
| /// The payload of the websocket request | ||
| /// </summary> | ||
| public GraphQLRequest Payload | ||
| public object Payload |
sungam3r
reviewed
Oct 5, 2020
| <Description>GraphQL basic types</Description> | ||
| <RootNamespace>GraphQL</RootNamespace> | ||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
| <Version>1.0.0</Version> |
sungam3r
reviewed
Oct 5, 2020
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;net461</TargetFrameworks> | ||
| <RootNamespace>GraphQL.Client.Http</RootNamespace> | ||
| <Authors>Deinok,Alexander Rose,graphql-dotnet</Authors> |
Member
There was a problem hiding this comment.
sungam3r
requested changes
Oct 5, 2020
Member
sungam3r
left a comment
sungam3r
left a comment
There was a problem hiding this comment.
These edits don't seem right to me.
Collaborator
|
@codewalkerdan Thanks for your contribution. I'm closing this in favor of #294, which basically does the same thing albeit keeping types and names close to the Apollo GraphQL over WebSocket Protocol Spec, which this library aims to fully implement. |
Author
|
Sorry for not replying. I have little time, but thank you for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not just authorization, but other headers could be added that may be required when initializing a web socket connection.
It supports adding authorization tokens