Add websocket ConnectionParams object #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2020
Closed
sungam3r
reviewed
Oct 7, 2020
src/GraphQL.Client.Abstractions.Websocket/GraphQLWebSocketRequest.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Oct 7, 2020
sungam3r
reviewed
Oct 8, 2020
rose-a
force-pushed
the
add-websocket-connection-params
branch
from
6b86a91 to
937dc9c
Compare
sungam3r
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is specified in the Apollo GraphQL over WebSocket Protocol specification and there is currently no way to set this.
Fixes #269, fixes #250
This does essentially the same as #285 albeit keeping Apollos naming convention.