Skip to content

Conversation

@rose-a
Copy link
Collaborator

@rose-a rose-a commented Oct 8, 2020

Fixes #293

@rose-a rose-a requested a review from sungam3r October 8, 2020 20:56
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new GraphQLRequest() ? It seems like there could be any type of payload.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that should be replaced by the payload from #294... I'll fix this as soon as the former gets merged...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just didn't want to mix them up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@rose-a rose-a force-pushed the fix-graphql-websocket-protocol branch from 572edf7 to 1a4fc38 Compare October 12, 2020 18:37
@rose-a rose-a merged commit 1970376 into master Oct 12, 2020
@rose-a rose-a deleted the fix-graphql-websocket-protocol branch October 12, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix implementation details of the GraphQL over WebSocket Protocol

3 participants