This repository was archived by the owner on Jul 25, 2024. It is now read-only.
Extract GraphiQL from core Endpoint plug #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aweiker
commented
Mar 11, 2016
aweiker
commented
- Version that can only execute queries
- Separate version that can load GraphiQL, fixes Extract GraphiQL from core Endpoint plug #16
- Allow queries to be retrieved from the server side either through a function or from a passed in option
- Upgrade to GraphiQL 0.6.1
* Version that can only execute queries * Seperate version that can load GraphiQL
aweiker
changed the title
This provides the abiilty of a set of query operations to be defined alongsie the schema.
lib/graphql/plug.ex
Outdated
| s -> s | ||
| end | ||
|
|
||
| root_value = Keyword.get(opts, :root_value, %{}) |
Member
There was a problem hiding this comment.
As discussed I think that the core params need to be extracted in the core Endpoint plug and this decorates and adds the extra behaviour -graphiql in this case
Member
|
Looks good, nice work! As discussed, we need to name the modules here more clearly:
|
* Improving validation of functions
* Unify query tests into a single file * Add init tests for each plug
joshprice
changed the title
Member
|
Awesome work, thanks! 🚀 |
joshprice
pushed a commit
that referenced
this pull request
Mar 16, 2016
Extract GraphiQL from core Endpoint plug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.