Hive client logger breaks JSON based logging

[holzerch]

Hello Hive team,

we configured the Hive client to use our own JSON based logger (pino). The idea of a JSON based logger is that all the data of a single log entry is part of a single JSON entry. We noticed now that your internal HiveLogger breaks this logic by splitting up all lines of a stack trace into different log lines/entries

return {
    [hiveSymbol]: context,
    info: (message: string) => {
      logger.info(`${path} ${message}`);
    },
    error: (error: any, ...data: any[]) => {
      if (error.stack) {
        for (const stack of error.stack.split('\n')) {
          logger.error(`${path} ${stack}`);
        }
      } else {
        logger.error(`${path} ${String(error)}`, ...data);
      }
    },
  };

See:

console/packages/libraries/core/src/client/utils.ts

Line 208 in a068362

for (const stack of error.stack.split('\n')) {

I don't know why you are doing this, but it is very bad, because the log information is now split up and very hard to read.

Could you please remove this logic at least when a custom logger is configured?

Thanks
Christian

[n1ru4l]

We now have betetr support for JSON based loggers via https://github.com/graphql-hive/console/releases/tag/%40graphql-hive%2Fcore%400.18.0

[holzerch]

@n1ru4l thanks for the update. But if I understand the change correctly there is no way anymore to plugin in your own logger but only the Hive Logger. This is for sure not something we want.

[enisdenjo]

There is! Hive Logger supports "writers" where you can plug in your own logger or use some of our official writers. Read more in the documentation.

[holzerch]

ah perfect, thank you!