Skip to content

fix integration test failing due to zero division #7312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2025
Merged

fix integration test failing due to zero division #7312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cbd2d1
fix integration test failing due to zero division
n1ru4l Nov 25, 2025
e4c557b
fix
n1ru4l Nov 25, 2025
3595bf2
Apply suggestions from code review
n1ru4l Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/services/api/src/modules/schema/providers/breaking-schema-changes-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,31 @@ export class BreakingSchemaChangeUsageHelper {

return {
topAffectedOperations: schemaChange.usageStatistics.topAffectedOperations.map(operation => {
const percentage = (operation.count / metadata.usage.totalRequestCount) * 100;
// Note:
// "metadata.usage.totalRequestCount" is sometimes 0 in case of a integration test
// causing a zero devision and GraphQL exception,
// because we aggressively poll for the schema change after publishing usage data
// it seems like clickhouse slighty lags behind for the materialized view here.
// since it only happens in context of an integration test (no production issues)
// we can safely treat 0 as 1 request.
const totalRequestCount = Math.max(1, metadata.usage.totalRequestCount);
const percentage = (operation.count / totalRequestCount) * 100;
return {
...operation,
percentage,
targetIds: metadata.settings.targets.map(target => target.id),
};
}),
topAffectedClients: schemaChange.usageStatistics.topAffectedClients.map(client => {
const percentage = (client.count / metadata.usage.totalRequestCount) * 100;
// Note:
// "metadata.usage.totalRequestCount" is sometimes 0 in case of a integration test
// causing a zero devision and GraphQL exception,
// because we aggressively poll for the schema change after publishing usage data
// it seems like clickhouse slighty lags behind for the materialized view here.
// since it only happens in context of an integration test (no production issues)
// we can safely treat 0 as 1 request.
const totalRequestCount = Math.max(1, metadata.usage.totalRequestCount);
const percentage = (client.count / totalRequestCount) * 100;

return {
...client,
Expand Down
Loading