Skip to content

Conversation

@ardatan
Copy link
Member

@ardatan ardatan commented Dec 9, 2025

Creates a dummy project and publishes a subgraph then tests if Apollo Router can fetch the supergraph from the CDN and sends usage reports to Hive Console properly

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ardatan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new set of integration tests designed to validate the functionality of the Apollo Router within the existing system. The tests simulate a full workflow, from schema publication to querying the router and verifying usage report collection, ensuring robust interaction with the Hive CDN. This enhancement improves the overall test coverage and reliability of the system's integration with Apollo Router.

Highlights

  • New Apollo Router Integration Test Suite: A comprehensive set of integration tests has been added to validate the Apollo Router's functionality, specifically focusing on its ability to fetch a supergraph and send usage reports to the Hive CDN.
  • Dedicated Test Script: New test:integration:apollo-router scripts have been introduced at both the root and integration-tests/package.json levels, providing a streamlined way to execute these specific Apollo Router tests.
  • Conditional Test Execution: The vite.config.ts has been updated to conditionally exclude the Apollo Router tests from general integration test runs. They will only execute when the TEST_APOLLO_ROUTER environment variable is explicitly set, allowing for targeted testing.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/tests-integration.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 8.13.0-alpha-20251210010021-160a3d988329923ed31eae6549cbd5068289814a npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7394.hive-storybook.pages.dev

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds integration tests for the Apollo Router. I've left a couple of comments to improve test robustness and adhere to the style guide.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

💻 Website Preview

The latest changes are available as preview in: https://pr-7394.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 160a3d988329923ed31eae6549cbd5068289814a

Copy link
Contributor

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

just one minor thing: shard index 3 now tries to run test from zod in node_modules? xD

Copy link
Contributor

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😍

@ardatan ardatan merged commit 856bf7e into main Dec 10, 2025
27 checks passed
@ardatan ardatan deleted the apollo-router-integration-tests branch December 10, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants