Conversation
…rsion` as extra default in addition to `x-` ones
Summary of ChangesHello @ardatan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an enhancement to the JavaScript SDK by extending its default client information detection to include Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.45.1-alpha-20251212115012-f9e6f24cd70db99ed5d5419def6023f461fd1fd6 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.56.1-alpha-20251212115012-f9e6f24cd70db99ed5d5419def6023f461fd1fd6 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.18.1-alpha-20251212115012-f9e6f24cd70db99ed5d5419def6023f461fd1fd6 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.1-alpha-20251212115012-f9e6f24cd70db99ed5d5419def6023f461fd1fd6 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.46.1-alpha-20251212115012-f9e6f24cd70db99ed5d5419def6023f461fd1fd6 |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7414.hive-storybook.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request enhances the JS SDK by adding support for graphql-client-name and graphql-client-version headers, which is a great improvement for interoperability with other tools. The implementation is well-structured, and the inclusion of tests and documentation updates is appreciated. However, I've identified a high-severity regression regarding the precedence of custom header names and a bug in a conditional check. I've also found a minor typo in the documentation. My review includes specific suggestions to address these points.
| key within the `connectionParams`. | ||
| By default, the client information is retrieved by looking up the client information headers in the | ||
| HTTP request. Those are `x-graphql-client-name` or `graphql-client-name` for the client name and | ||
| `x-graphql-client-version` or `graphql-client-version` for the client version.For operations |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
💻 Website PreviewThe latest changes are available as preview in: https://pr-7414.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
Today by default,
x-graphql-client-ones are used by default but Apollo Router plugin and some other popular products are using the ones withoutx-by default. So in order to have an easier migration from other tools, this PR makes JS SDK to respect unprefixed version of those headers, too.