fix(core): clear persisted documents caches on dispose to prevent memory leaks

[adambenhassen]

Background

The dispose() function wasn't clearing persistedDocumentsCache or fetchCache, causing memory to accumulate when running tests with leak detection on Node 20

https://github.com/graphql-hive/gateway/actions/runs/21066002133/job/60583665971?pr=1834

[gemini-code-assist]

Summary of Changes

Hello @adambenhassen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a memory leak issue within the core library's persisted documents client. By ensuring that both the persistedDocumentsCache and fetchCache are cleared when the dispose() function is called, it prevents memory accumulation, particularly in testing environments where components are frequently initialized and torn down.

Highlights

• Memory Leak Fix: The dispose() function in packages/libraries/core/src/client/persisted-documents.ts now explicitly clears persistedDocumentsCache and fetchCache.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
@graphql-hive/apollo	0.47.2-alpha-20260122233516-2c10d90bd06afaa36a2676c8d6bc260ff1cf0d7a	npm ↗︎ unpkg ↗︎
@graphql-hive/cli	0.57.4-alpha-20260122233516-2c10d90bd06afaa36a2676c8d6bc260ff1cf0d7a	npm ↗︎ unpkg ↗︎
@graphql-hive/core	0.20.2-alpha-20260122233516-2c10d90bd06afaa36a2676c8d6bc260ff1cf0d7a	npm ↗︎ unpkg ↗︎
@graphql-hive/envelop	0.40.4-alpha-20260122233516-2c10d90bd06afaa36a2676c8d6bc260ff1cf0d7a	npm ↗︎ unpkg ↗︎
@graphql-hive/yoga	0.47.2-alpha-20260122233516-2c10d90bd06afaa36a2676c8d6bc260ff1cf0d7a	npm ↗︎ unpkg ↗︎
hive	9.2.0-alpha-20260122233516-2c10d90bd06afaa36a2676c8d6bc260ff1cf0d7a	npm ↗︎ unpkg ↗︎

[gemini-code-assist]

Code Review

This change correctly addresses a memory leak by clearing persistedDocumentsCache and fetchCache in the dispose function. The fix is straightforward and necessary to prevent memory accumulation, especially in test environments where instances are frequently created and destroyed.

[github-actions]

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7541.hive-storybook.pages.dev

[github-actions]

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 2c10d90bd06afaa36a2676c8d6bc260ff1cf0d7a

[github-actions]

💻 Website Preview

The latest changes are available as preview in: https://pr-7541.hive-landing-page.pages.dev