clean up sub page nav button/link usage and various ui colors

[jonathanawesome]

Description

This PR fixes some color issues in light mode and creates/uses a shared component for use across NavLayouts.

[gemini-code-assist]

Summary of Changes

Hello @jonathanawesome, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the consistency and maintainability of sub-page navigation within the application. It introduces a dedicated, reusable SubPageNavigationLink component that encapsulates the styling and behavior for these navigation elements. This refactoring centralizes the logic for active and inactive states, including a fix for a specific color issue in light mode, and streamlines the implementation across different sections of the application that utilize NavLayouts.

Highlights

• New Shared Component: A new SubPageNavigationLink component has been introduced to standardize the navigation links used in sub-page layouts.
• Color Issue Fix: The new component addresses and fixes a color display issue specifically in light mode for active navigation links.
• Refactoring and Consistency: Existing direct usages of Button components for sub-page navigation across various NavLayouts have been replaced with the new SubPageNavigationLink component, improving consistency and maintainability.

Changelog

• packages/web/app/src/components/navigation/sub-page-navigation-link.tsx
  • Added a new React component SubPageNavigationLink to provide a standardized button for sub-page navigation.
  • Implemented specific styling for active and inactive states, including a fix for light mode color issues.
• packages/web/app/src/pages/organization-members.tsx
  • Imported the new SubPageNavigationLink component.
  • Removed direct imports of Button and cn utilities as they are now handled within the new component.
  • Replaced the manual rendering of Button components for sub-page navigation with the SubPageNavigationLink component.
• packages/web/app/src/pages/organization-settings.tsx
  • Imported the new SubPageNavigationLink component.
  • Removed the direct import of the cn utility.
  • Replaced the manual rendering of Button components for sub-page navigation with the SubPageNavigationLink component.
• packages/web/app/src/pages/project-settings.tsx
  • Imported the new SubPageNavigationLink component.
  • Removed the direct import of the cn utility.
  • Replaced the manual rendering of Button components for sub-page navigation with the SubPageNavigationLink component.
• packages/web/app/src/pages/target-settings.tsx
  • Imported the new SubPageNavigationLink component.
  • Removed the direct import of the cn utility.
  • Replaced the manual rendering of Button components for sub-page navigation with the SubPageNavigationLink component.
• packages/web/app/src/stories/sub-page-layout.stories.tsx
  • Updated the Storybook example to use the new SubPageNavigationLink component instead of the generic Button.

Activity

• The pull request was opened by jonathanawesome with an initial commit.
• No further review comments or updates have been made since the PR was opened.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that centralizes the sub-page navigation buttons into a shared SubPageNavigationLink component, improving code reuse and fixing a styling issue. I've identified one likely unintentional removal of a test attribute and have also provided a suggestion to improve the accessibility of the new component.

[github-actions]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
hive	9.3.1-alpha-20260205222421-8a0254561b48ae672a47948563178063c0ae6f98	npm ↗︎ unpkg ↗︎

[github-actions]

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7641.hive-storybook.pages.dev

[github-actions]

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 8a0254561b48ae672a47948563178063c0ae6f98

[github-actions]

💻 Website Preview

The latest changes are available as preview in: https://pr-7641.hive-landing-page.pages.dev