Skip to content

feat: bump federation composition#7859

Merged
n1ru4l merged 1 commit intomainfrom
chore-federation-composition
Mar 17, 2026
Merged

feat: bump federation composition#7859
n1ru4l merged 1 commit intomainfrom
chore-federation-composition

Conversation

@n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Mar 17, 2026

Improve federation composition

  • Support file: protocol and non-RFC 3986 in imported link url arguments
  • Fix supergraph @join__field emission for Federation v1 @external fields and improve override/requires edge-case handling.
    • Drop Federation v1 @join__field(external: true) fields based on key usage in the subgraph instead of aggregated field key usage across subgraphs.
    • Avoid emitting redundant @join__field(external: true) metadata when a field is only required through overridden paths.
    • Tighten @join__field emission around @OverRide and interface type fields.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the @theguild/federation-composition package across the repository to version 0.22.1. This update brings significant enhancements to GraphQL Federation composition, primarily focusing on improving the accuracy and correctness of supergraph schema generation. The changes address specific issues related to @external fields, @override directives, and link URL parsing, leading to a more reliable and compliant federation setup.

Highlights

  • Federation Composition Improvements: Improved the overall federation composition logic, addressing several edge cases and enhancing robustness.
  • Link URL Argument Support: Added support for the file: protocol and non-RFC 3986 compliant URLs in imported link arguments.
  • Supergraph @join__field Emission Fixes: Fixed issues with @join__field emission for Federation v1 @external fields and refined handling of override/requires directives. This includes dropping @join__field(external: true) based on subgraph key usage, avoiding redundant metadata for overridden paths, and tightening emission around @override and interface type fields.
Changelog
  • .changeset/five-dogs-hear.md
    • Improve federation composition
    • Support file: protocol and non-RFC 3986 in imported link url arguments
    • Fix supergraph @join__field emission for Federation v1 @external fields and improve override/requires edge-case handling.
    • Drop Federation v1 @join__field(external: true) fields based on key usage in the subgraph instead of aggregated field key usage across subgraphs.
    • Avoid emitting redundant @join__field(external: true) metadata when a field is only required through overridden paths.
    • Tighten @join__field emission around @OverRide and interface type fields.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@n1ru4l n1ru4l force-pushed the chore-federation-composition branch from 5561d53 to 8f79ecc Compare March 17, 2026 12:57
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @theguild/federation-composition dependency to version 0.22.1 across various packages. This bump incorporates several improvements and bug fixes related to federation composition, as documented in the new changeset file. The changes consist of dependency updates in package.json files and the addition of a changeset file.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/cli 0.59.0-alpha-20260317132044-5acb547ab65073f9f11d1740e7ecf260344f44f3 npm ↗︎ unpkg ↗︎
hive 10.2.0-alpha-20260317132044-5acb547ab65073f9f11d1740e7ecf260344f44f3 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-7859.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 5acb547ab65073f9f11d1740e7ecf260344f44f3

@n1ru4l n1ru4l force-pushed the chore-federation-composition branch from e65a72f to 5acb547 Compare March 17, 2026 13:19
@n1ru4l n1ru4l merged commit bf00fbc into main Mar 17, 2026
21 checks passed
@n1ru4l n1ru4l deleted the chore-federation-composition branch March 17, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant