fix(dashboard): make toast text selectable#7894
fix(dashboard): make toast text selectable#7894mvanhorn wants to merge 1 commit intographql-hive:mainfrom
Conversation
Add `select-text` to ToastTitle and ToastDescription so users can select and copy error messages instead of triggering swipe gestures. Fixes graphql-hive#7012 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the accessibility of toast notifications by enabling text selection. It resolves a previous issue where the swipe gesture handling interfered with the browser's text selection behavior. The fix is implemented by applying the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request makes text in toasts selectable by adding the select-text utility class to the ToastTitle and ToastDescription components. The change is straightforward and correctly addresses the issue of text selection being disabled by swipe gesture handlers. The implementation is consistent with the existing codebase.
Background
Resolves #7012. Closes #7914 Toast text cannot be selected because Radix UI Toast's swipe gesture handling intercepts pointer events, overriding the browser's text selection behavior.
Description
Adds
select-text(Tailwind'suser-select: text) toToastTitleandToastDescriptioninpackages/web/app/src/components/ui/toast.tsx. This restores text selection within toast content while preserving the swipe-to-dismiss behavior on the toast container itself.The codebase already uses
select-textandselect-noneutilities across other components (dropdown menus, sidebar badges, callouts).Checklist
This contribution was developed with AI assistance (Claude Code).