Skip to content

bump vite and vitest peer dependency#7953

Merged
n1ru4l merged 1 commit intomainfrom
chore-vulnerabilities-2026-04-08
Apr 8, 2026
Merged

bump vite and vitest peer dependency#7953
n1ru4l merged 1 commit intomainfrom
chore-vulnerabilities-2026-04-08

Conversation

@n1ru4l
Copy link
Copy Markdown
Contributor

@n1ru4l n1ru4l commented Apr 8, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vitest dependency from version 4.0.9 to 4.1.3 across multiple package.json files. Feedback indicates that the version 4.1.3 is likely incorrect, as Vitest is currently on major version 3.x, suggesting a potential package name or version mismatch with vite.

Comment thread package.json
"typescript": "5.7.3",
"vite-tsconfig-paths": "5.1.4",
"vitest": "4.0.9"
"vitest": "4.1.3"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 4.1.3 for vitest appears to be incorrect. The current major version of Vitest is 3.x, and there is no version 4.x available on npm. This version number matches vite releases (e.g., vite@4.1.3), which suggests a potential package name/version mismatch.

Additionally, the PR title mentions "peer dependency" and "vite", but the diff only shows updates to vitest in devDependencies across several package.json files. No peerDependencies or vite entries are modified in this diff. Please verify if you intended to update vite or if you should be using a valid vitest version (e.g., ^3.0.0). This issue persists across all modified package.json files in this PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 76d406011cd984e040683e0d95fdea04940a779b

@n1ru4l n1ru4l marked this pull request as ready for review April 8, 2026 06:48
@n1ru4l n1ru4l merged commit 0d81a7a into main Apr 8, 2026
25 checks passed
@n1ru4l n1ru4l deleted the chore-vulnerabilities-2026-04-08 branch April 8, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant