Conversation
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the development documentation to reference the package.json engines entry for Node.js and pnpm versions, includes fnm in the setup instructions, and mentions manual service startup. Feedback suggests clarifying the Node.js version source in the setup steps to avoid ambiguity.
| - In the root of the repo, run `nvm use` (or `fnm use`) to use the same version of node as mentioned | ||
| above |
There was a problem hiding this comment.
The phrase "as mentioned above" is now ambiguous because the specific version is no longer explicitly stated in the prerequisites list, but rather referenced as being in package.json. It's clearer to refer directly to the source of truth.
| - In the root of the repo, run `nvm use` (or `fnm use`) to use the same version of node as mentioned | |
| above | |
| - In the root of the repo, run nvm use (or fnm use) to use the Node.js version specified in package.json |
1 participant
No need to hardcode Node.js and pnpm versions, they update frequently.