Improve schema OSGi whiteboard update performance by batching #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the ability to delay the update of the schema through a config option. By default this is 0, leaving the behaviour unchanged, and no penalty is paid. If the delay is set to a non zero value, it only updates the schema if no changes to the whiteboard have happened within that delay timeout. Also fixed up a couple of things with the whiteboard. Using policy=DYNAMIC is the normal approach, the component can activate and gets references added as appropriate. The "typesProviders" method was in error as the name didn't match the unbind. I believe that what was happenning before is that the component was being activated and deactivated each time a new reference was added. Now it's activated once and the whiteboard works correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the ability to delay the update of the schema through a config
option. By default this is 0, leaving the behaviour unchanged, and no
penalty is paid.
If the delay is set to a non zero value, it only updates the schema if no
changes to the whiteboard have happened within that delay timeout.
Also fixed up a couple of things with the whiteboard. Using
policy=DYNAMIC is the normal approach, the component can activate
and gets references added as appropriate. The "typesProviders" method
was in error as the name didn't match the unbind. I believe that what
was happenning before is that the component was being activated
and deactivated each time a new reference was added. Now it's activated
once and the whiteboard works correctly.
Note that my preference would be to set the default delay to 150ms.
This will give improved behaviour for most people in my opinion.
I've left the default as 0 though so that the current behaviour is maintained,
and there is no impact of this change at all otherwise.