separated out logging of errors to separate overriddable method in DefaultGraphQLErrorHandler #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aultGraphQLErrorHandler so that entire processErrors method does not need to be overridden just to change which errors get logged by users of DefaultGraphQLErrorHandler
Member
|
Thanks @bsara! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
Separated out logging of errors to separate overriddable method in DefaultGraphQLErrorHandler so that entire processErrors method does not need to be overridden just to change which errors get logged by users of DefaultGraphQLErrorHandler.
Why?
When a user of this library wants to override DefaultGraphQLErrorHandler to create their own but retain the functionality of DefaultGraphQLErrorHandler without copying the code, that user cannot change which errors are logged unless they reimplement the entire processErrors method. This PR separates out the logging of errors into a separate method that can be overridden to prevent the need to reimplement all of processErrors just to change which errors are logged.