Added support for instrumentation #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, thanks! |
Contributor
Author
|
@apottere I know this is closed but I'm not sure where else to ask it. Do you know when the next version containing this will be released? We're trying to decide whether or not to just add our fork into our pom.xml in some weird way or just wait for the next version. Thanks! |
Contributor
|
I can cut a release tomorrow
…On Mon, May 8, 2017, 8:20 PM ronald-d-rogers ***@***.***> wrote:
@apottere <https://github.com/apottere> I know this is closed but I'm not
sure where else to ask it. Do you know when the next version containing
this will be released? We're trying to decide whether or not to just add
our fork into maven as a dependency in some weird way or just wait for the
next version. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB44WExjj4GZf-ADnU3Bvbmde-qhZ3jlks5r37FSgaJpZM4NTQ5V>
.
|
Contributor
Author
|
Cool, thanks alot! |
Contributor
|
@ronald-d-rogers |
Contributor
Author
|
Great, thanks again for the quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty to add extensibility for instrumentation.
Not sure if this is all that needs to be done.
All tests still seem to pass.