Subscription support #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-support # Conflicts: # build.gradle # gradle.properties # gradle/wrapper/gradle-wrapper.properties # src/main/java/graphql/servlet/GraphQLContext.java # src/main/java/graphql/servlet/GraphQLServlet.java # src/main/java/graphql/servlet/SimpleGraphQLServlet.java
…n-support # Conflicts: # build.gradle # gradle.properties # gradle/wrapper/gradle-wrapper.properties # src/main/java/graphql/servlet/GraphQLContext.java # src/main/java/graphql/servlet/GraphQLServlet.java # src/main/java/graphql/servlet/SimpleGraphQLServlet.java
apottere
approved these changes
Jul 24, 2018
Contributor
|
@oliemansm I pushed one commit to just finish up stuff I had forgotten to implement. I was able to test the apollo protocol, do you want to test the fallback one? I was getting some strange errors in the logs after I shut down my test server and the client was trying to reconnect, for some reason when there were reconnections shutting down took about 10-15s. I don't think it's a huge deal, so if everything looks good to you go ahead and merge it and I'll release this and the servlet. |
Contributor
|
Sample of the error: |
Member
Author
|
@apottere Great thanks, I'll take a look right away! |
|
Hi, we just recently updated past the version that this PR was merged into, and are immediately encountering an issue. Why was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated your subscription support branch by merging in all latest changes. Created an example in the spring-boot-starter project as well that works now (with the
FallbackSubscriptionProtocolHandler, haven't tested theApolloSubscriptionProtocolHandleryet). Increased the version number to 6.0.0 since there are a lot of breaking changes in the public API here. Would like to merge this one asap so people can start using it, so please review.Will push the PR for the spring-boot-starter project in a minute as well.