[Feature] Expose HTTP Request Elapsed Time in ExecutionResult.extensions for RequestsHTTPTransport

[adamzev]

It would be useful for performance monitoring, logging and debugging if the HTTP request elapsed time (duration) was included in the ExecutionResult returned by RequestsHTTPTransport. The extensions field for implementation-specific data seems like the place to expose this data.

The underlying requests.Response object has .elapsed, but this is not currently exposed via any public API or returned result.

Proposed Solution

• When constructing the ExecutionResult in RequestsHTTPTransport, add a key (e.g., "elapsed") to the extensions dictionary, with the value set to response.elapsed.total_seconds().
• This information will then be accessible as result.extensions["elapsed"] for any consumer of the library, without breaking any existing API.

Alternatives Considered

• Subclassing RequestsHTTPTransport and overriding execute. This is not practical, as internal APIs are not designed for easy override, and the requests.Response object is not exposed.

Thanks!

[leszekhanusz]

The extensions field of ExecutionResult is supposed to be something returned by the backend, not generated by the client.

You can subclass RequestsHTTPTransport and override _prepare_result and add another attribute to the ExecutionResult

[adamzev]

Thanks, I think that'll meet out needs although it would be nice to be able to do it without overriding a method marked as private. I'm not sure where would be better to put it but if there is a place you think it'd fit, that would be a good feature to have native support for. I'll close this issue out though since we have something that will work for us and the idea that I proposed doesn't fit the intended use.

Thanks for being responsive and your work on the library!

[adamzev]

One issue with adding an attribute to ExecutionResult is that it uses slots:

class ExecutionResult:  # noqa: PLW1641
    """The result of GraphQL execution.

    - ``data`` is the result of a successful execution of the query.
    - ``errors`` is included when any errors occurred as a non-empty list.
    - ``extensions`` is reserved for adding non-standard properties.
    """

    __slots__ = "data", "errors", "extensions"