Update Readme to include more example code#32
Closed
ahussain3 wants to merge 1 commit intographql-python:masterfrom
Closed
Update Readme to include more example code#32ahussain3 wants to merge 1 commit intographql-python:masterfrom
ahussain3 wants to merge 1 commit intographql-python:masterfrom
Conversation
As discussed in [graphql-python#29 (comment)], it would be great if the readme included more example code to help people get started.
Closed
|
Thank you, it works @ahussain3 |
clintonb
reviewed
Jun 20, 2018
clintonb
left a comment
clintonb
left a comment
There was a problem hiding this comment.
This is quite helpful. I would love to see this merged, even if my comments are addressed in a later pull request.
| client.execute(query) | ||
| ``` | ||
|
|
||
| To execute against a graphQL API. (We get the schema by using introspection). |
| from gql import gql, Client | ||
| from gql.transport.requests import RequestsHTTPTransport | ||
|
|
||
| _transport = RequestsHTTPTransport( |
There was a problem hiding this comment.
It would be helpful to explain that this class comes from the requests library, and takes the various arguments (e.g. headers, auth).
|
|
||
| To execute against a graphQL API. (We get the schema by using introspection). | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Adding python after these backticks would make this easier to read. Same for line 67 below.
|
Any update on getting this merged? |
|
I found this super helpful. I hope it gets merged soon! |
nicolasassi
approved these changes
Sep 16, 2019
Author
|
Sorry, I don't actually know what the process is for merging something in this codebase. If I need to do anything more, please let me know. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in [https://github.com//issues/29#issuecomment-384472839], it would be great if the readme included more example code to help people get started.