Pass context to serializer so authentication works #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw that maybe I'm duplicating issue #228 altough that PR is a more general way of instantiating serializers. |
spockNinja
reviewed
Oct 14, 2017
| @classmethod | ||
| def mutate_and_get_payload(cls, root, info, **input): | ||
| serializer = cls._meta.serializer_class(data=input) | ||
| serializer = cls._meta.serializer_class(data=input, context=getattr(info, 'context', None)) |
There was a problem hiding this comment.
I believe there is a chance this might break if someone has overridden their serializer class's __init__ in such a way as to not accept **kwargs. Even then, if they don't pop the context kwarg off before the base DRF Field class is resolved, I think this could cause an error.
|
Duplicate functionality with #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without passing the context when creating the serializer you can't access the user in validation. Simply add the context when creating the serializer class fixes the authentication.