Skip to content

Pass context to serializer so authentication works #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Pass context to serializer so authentication works #285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa8dc54
Pass context to serializer so authentication works
glopezmartin Oct 9, 2017
210aac6
Ensure there is a context to pass
glopezmartin Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graphene_django/rest_framework/mutation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def __init_subclass_with_meta__(cls, serializer_class=None,

@classmethod
def mutate_and_get_payload(cls, root, info, **input):
serializer = cls._meta.serializer_class(data=input)
serializer = cls._meta.serializer_class(data=input, context=getattr(info, 'context', None))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is a chance this might break if someone has overridden their serializer class's __init__ in such a way as to not accept **kwargs. Even then, if they don't pop the context kwarg off before the base DRF Field class is resolved, I think this could cause an error.


if serializer.is_valid():
return cls.perform_mutate(serializer, info)
Expand Down