Warning about normal methods in juniper::object impl blocks#545
Merged
LegNeato merged 2 commits intographql-rust:masterfrom Mar 4, 2020
Merged
Warning about normal methods in juniper::object impl blocks#545LegNeato merged 2 commits intographql-rust:masterfrom
LegNeato merged 2 commits intographql-rust:masterfrom
Conversation
There's a comment [here](https://docs.rs/juniper/0.14.2/juniper/attr.object.html) that only GraphQL fields can be specified in `#[juniper::object]` impl block, yet in the book it was not specified, I needed help to get the idea to try it. I simply copied that information because it feels important.
LegNeato
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a comment here that only GraphQL fields can be specified in
#[juniper::object]impl block, yet in the book it was not specified, I needed help to get the idea of separating mynewmethod in another impl block.I simply copied that information in the book because it feels important; one would not know of this only by reading the book.