Skip to content

Conversation

@kouak
Copy link
Contributor

@kouak kouak commented Oct 15, 2016

I ran into a few gotchas implementing dataloader with RethinkDB and I thought I'd share my workarounds.

This PR provides a RethinkDB implementation example.

Also, english is not my first language, so feel free to comment on poor phrasing :).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5ff6f86 on kouak:master into da2fb5f on facebook:master.

@blakeembrey
Copy link
Contributor

Did you investigate the trade-offs of this approach vs the simpler r.map(keys, (key) => r.table(x).get(key))?

@leebyron
Copy link
Contributor

This is pretty long vs the others in there - maybe it makes sense to set up a cookbook of examples?

@kouak, @blakeembrey what do you think about adding a folder examples/ under which we could have something like this as rethinkdb.md or rethinkdb.js

leebyron added a commit that referenced this pull request Jan 30, 2017
@leebyron leebyron merged commit 5ff6f86 into graphql:master Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants