type lookup in hint fails

[timsuchanek]

Hi,

we're using the codemirror-graphql in the GraphQL Playground and experience problems, that the type property of a suggestion is undefined.
It happens in this line of code:
https://github.com/graphql/codemirror-graphql/blob/master/src/hint.js#L66

The problem is, that item.detail can contain ! in the case of a non-nullable type.
item.detail comes from here https://github.com/graphql/graphql-language-service/blob/master/packages/interface/src/getAutocompleteSuggestions.js#L97

schema.getType() however is just returning getTypeMap()[name] - as there is no type with the name User!, undefined is returned.
https://github.com/graphql/graphql-js/blob/master/src/type/schema.js#L182

Now is the question what the solution for this could be.
The quick-fix, that would work for us, is just not calling .getType() in hint anymore.
But I guess that the type lookup has been added for a reason.

@asiandrummer would be awesome to hear your take on that.

Thanks!

[asiandrummer]

@timsuchanek sorry for getting to this late. This looks like a bug - thanks for finding it! I guess it's not only for non-nullable types - list types could also cause a problem here, no?

I can't remember why exactly we're looking up a type here. I'm assuming this type lookup is there because we want to validate if the type name from item.detail is in fact existing in the schema provided. I think a correct fix is to determine if a type is a "wrapping type" and deal with each case properly. Thankfully it seems like we already have helper methods to work with these!

Would you be interested in creating PR for the fix maybe?

cc @schickling

[acao]

@timsuchanek thanks for your fix for this, I'm going to consider this resolved

[acao]

@yoshiakis is this not resolved yet? i think i mistook the PR above as having solved this