Skip to content

Consider removing graphql-config-extension-graphcool and graphql-config-extension-prisma from graphql-playground-html.  #493

@wtgtybhertgeghgtwtg

Description

@wtgtybhertgeghgtwtg

This issue pertains to the following package(s):

  • GraphQL Playground - Electron App
  • GraphQL Playground HTML
  • GraphQL Playground
  • GraphQL Playground Express Middleware
  • GraphQL Playground Hapi Middleware
  • GraphQL Playground Koa Middleware
  • GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

N/A

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

1.4.4

What is the expected behavior?

graphql-playground-html should not package 3rd party configuration parsers.

What is the actual behavior?

graphql-playground-html packages 3rd party configuration parsers.

What steps may we take to reproduce the behavior?

Look at the package.json.

Please provide a gif or image of the issue for a quicker response/fix.

In short:

  • Users of graphql-playground are not necessarily users of graphcool or prisma.
  • There is no documentation for using graphcool.yml or prisma.yml for configuration.
  • Configuration would be expected to come from arguments or graphql-config.
  • graphql-config-extension-graphcool and graphql-config-extension-prisma increase the dependency tree by a non-trivial amount. Actually, most of the dependency tree is from those two and their transitive dependencies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions