Skip to content

fix list coercion examples #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix list coercion examples #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spec/Section 3 -- Type System.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,8 +1489,9 @@ Expected Type | Provided Value | Coerced Value
`[Int]` | `[1, "b", true]` | Error: Incorrect item value
`[Int]` | `1` | `[1]`
`[Int]` | `null` | `null`
`[[Int]]` | `[[1], [2, 3]]` | `[[1], [2, 3]`
`[[Int]]` | `[1, 2, 3]` | Error: Incorrect item value
`[[Int]]` | `[[1], [2, 3]]` | `[[1], [2, 3]]`
Copy link
Member

@IvanGoncharov IvanGoncharov Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix already proposed in:
https://github.com/facebook/graphql/pull/493/files

`[[Int]]` | `[1, 2, 3]` | `[[1], [2], [3]]`
`[[Int]]` | `[1, null, 3]` | `[[1], null, [3]]`
Copy link
Member

@IvanGoncharov IvanGoncharov Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both above cases are correct as is since this coercion applied only if:
http://facebook.github.io/graphql/June2018/#sec-Type-System.List

If the value passed as an input to a list type is NOT A LIST

`[[Int]]` | `1` | `[[1]]`
`[[Int]]` | `null` | `null`

Expand Down