New swapi-graphql service using netlify functions #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's will be a new build for swapi-graphql at netlify once graphql/swapi-graphql#162 is merged, we can merge this to take it live 🌍 I'm pretty sure the order of the last two rules will be fine. If the last one doesn't work, it will still work ``` /swapi-graphql/graphql https://swapi-graphql.netlify.com/.netlify/functions/index 200 ``` this just 200 redirects (non permanent?) which essentially is netlify terms for what nginx is a proxy_path so this will just make `graphiql.org/swapi-graphql/graphql` an alias for the lambda endpoint. see the PR's develop preview before it's merged if you want to see that default lambda path in action for yourself
acao
changed the title
orta
approved these changes
Nov 27, 2019
|
@orta feel free to merge when you get a chance, I don't have permissions to merge for this repo |
|
this needs one more line for the query strings |
so that we can support query parameters for http service requests. This will ensure we can support GET requests, and any other query parameters that might be used by express-graphql
|
@orta added the additional line. after discussion with @IvanGoncharov we may move the schema to https://swapi.graphql.org, so I need to request a CNAME record for that subdomain however, we can handle that in another PR later! so please merge away whenever you get a chance, no hurry 👍 . I modified the gh-pages build for the new URL. thanks for helping with this! |
|
Cool 👍 |
Dipeshwagle
pushed a commit
to Dipeshwagle/graphql.github.io
that referenced
this pull request
Aug 18, 2020
New swapi-graphql service using netlify functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can merge this PR, and https://swapi-graphql.netlify.com is live 🌍 at graphiql.org/swapi-graphql :D
here's where you can learn about the new features:
graphql/swapi-graphql#162
I'm pretty sure the order of the last two rules will be fine. If the last one doesn't work, it will still work
this just 200 redirects (non permanent?) which essentially is netlify terms for what nginx is a proxy_path
so this will just make
graphiql.org/swapi-graphql/graphqlan alias for the lambda endpoint. see the PR's develop preview before it's merged if you want to see that default lambda path in action for yourself