restore swapi server (netlify functions redux) #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acao
force-pushed
the
restore-server
branch
3 times, most recently
from
569d8c7 to
12c5f8f
Compare
acao
changed the title
acao
force-pushed
the
restore-server
branch
8 times, most recently
from
ab972fa to
d8d1c03
Compare
acao
changed the title
acao
requested review from
benjie
and removed request for
IvanGoncharov,
benjie and
leebyron
acao
added a commit
to acao/graphql.github.io
that referenced
this pull request
Nov 27, 2019
There's will be a new build for swapi-graphql at netlify once graphql/swapi-graphql#162 is merged, we can merge this to take it live 🌍 I'm pretty sure the order of the last two rules will be fine. If the last one doesn't work, it will still work ``` /swapi-graphql/graphql https://swapi-graphql.netlify.com/.netlify/functions/index 200 ``` this just 200 redirects (non permanent?) which essentially is netlify terms for what nginx is a proxy_path so this will just make `graphiql.org/swapi-graphql/graphql` an alias for the lambda endpoint. see the PR's develop preview before it's merged if you want to see that default lambda path in action for yourself
acao
force-pushed
the
restore-server
branch
2 times, most recently
from
ecf52b6 to
886989d
Compare
- update dependencies only as needed - add handler using aws-express-serverless (not ideal but it works!) - move code around to share with a local, normal express server - add build step for netlify-lambda script - add netlify deploy previews - upgrade GraphiQL version
orta
approved these changes
Nov 27, 2019
| </style> | ||
| <link rel="icon" href="favicon.ico"> | ||
| <link href="//cdn.jsdelivr.net/npm/graphiql@0.11.11/graphiql.css" rel="stylesheet" /> | ||
| <link type="text/css" href="//unpkg.com/graphiql@0.17.0/graphiql.css" rel="stylesheet" /> |
|
@orta thanks so much! this is gonna help me sleep a little better at night haha |
Dipeshwagle
pushed a commit
to Dipeshwagle/graphql.github.io
that referenced
this pull request
Aug 18, 2020
There's will be a new build for swapi-graphql at netlify once graphql/swapi-graphql#162 is merged, we can merge this to take it live 🌍 I'm pretty sure the order of the last two rules will be fine. If the last one doesn't work, it will still work ``` /swapi-graphql/graphql https://swapi-graphql.netlify.com/.netlify/functions/index 200 ``` this just 200 redirects (non permanent?) which essentially is netlify terms for what nginx is a proxy_path so this will just make `graphiql.org/swapi-graphql/graphql` an alias for the lambda endpoint. see the PR's develop preview before it's merged if you want to see that default lambda path in action for yourself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarncheck out the deploy preview below if you want to see it in action 🚀 ex