Codegen for global variable setter does not check if assignment is defined

[termi-official]

MWE

source file

class A {
public:
  explicit A(const char* person = "World"): person_(person){}
  void say_hello() const{
    std::cout << "Hello " << person_ << "!\n";
  }
  A& operator=(const A& a) = delete;
private:
  std::string person_;
};

A global_variable;

codegen

// [...]
void add_methods() const{
    auto& t = module_;

    DEBUG_MSG("Adding global_variable methods to provide access to the global variable global_variable (" __HERE__ ")");
    // defined in ./A.h:17:3
    t.method("global_variable", []()-> A& { return global_variable; });
    t.method("global_variable!", [](const A& val)-> A& { return global_variable = val; });
  }
// [...]

The generated code does not compile, because the statement global_variable = val is invalid, as the assignment operation has been deleted. Codegen should skip generating the setter method in this case.

[grasph]

Should be fixed with commit 5ebc002

[termi-official]

Interesting. It does fix my reproducer but looks like my specific case in MFEM is not covered by the tests here. Let me reiterate to see what is missing here.

[termi-official]

The problem still appears if default assignment is implicitly deleted.

class A
{
private:
   const int this_variable_deletes_default_assignment;
public:
   explicit A();
   ~A();
};

A a = A();

int main() {
    auto b = A();
    a = b;
    return 0;
}

Output:

<source>:14:7: error: object of type 'A' cannot be assigned because its copy assignment operator is implicitly deleted
   14 |     a = b;
      |       ^
<source>:4:14: note: copy assignment operator of 'A' is implicitly deleted because field 'this_variable_deletes_default_assignment' is of const-qualified type 'const int'
    4 |    const int this_variable_deletes_default_assignment;
      |              ^
1 error generated.
Compiler returned: 1