Skip to content

aws oidc menu and edit updates#53258

Merged
michellescripts merged 3 commits intomasterfrom
michelle/52895
Mar 24, 2025
Merged

aws oidc menu and edit updates#53258
michellescripts merged 3 commits intomasterfrom
michelle/52895

Conversation

@michellescripts
Copy link
Contributor

@michellescripts michellescripts commented Mar 20, 2025 •
edited
Loading

  • Remove actions menu from integrations list
  • Add actions menu to dashboard page
    • Update action menu to accept optional icon
    • If icon is present, display menu as square icon button
  • Edit updates:
    • Remove name input field
    • Put name in title
    • Remove custom edit styles
    • Set S3 ready only fields as disabled instead
    • Move reconfigure and edit buttons to footer
    • Move arn info tooltip to input helper text
Before & After

table before

table before

table after

table-after

new settings menu

new menu

edit before

Screen.Recording.2025-03-20.at.4.02.51.PM.mov

edit after

Screen.Recording.2025-03-20.at.3.39.05.PM.mov

Supports #52895

@michellescripts michellescripts changed the title aws oidc dashboard updates aws oidc menu and edit updates Mar 20, 2025
@michellescripts michellescripts force-pushed the michelle/52895 branch 6 times, most recently from 04f7b68 to 57abb47 Compare March 21, 2025 17:29
@michellescripts michellescripts marked this pull request as ready for review March 21, 2025 17:29
@github-actions github-actions bot requested review from kiosion and ravicious March 21, 2025 17:30
@michellescripts michellescripts added the no-changelog Indicates that a PR does not require a changelog entry label Mar 21, 2025
@michellescripts michellescripts added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit bc1b8f0 Mar 24, 2025
41 checks passed
@michellescripts michellescripts deleted the michelle/52895 branch March 24, 2025 21:50
@backport-bot-workflows
Copy link
Contributor

backport-bot-workflows bot commented Mar 24, 2025

@michellescripts See the table below for backport results.

Branch Result
branch/v17 Create PR

@michellescripts michellescripts mentioned this pull request Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avatus avatus avatus approved these changes

@rudream rudream rudream approved these changes

Assignees

No one assigned

Labels

backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michellescripts @avatus @rudream