[buddy] helm: add support for secondFactors#53274
Merged
Conversation
github-actions
bot
requested review from
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato and
zmb3
hugoShaka
changed the title
Contributor
|
Amplify deployment status
|
hugoShaka
requested review from
Joerger
and removed request for
mmcallister and
ptgott
tigrato
approved these changes
Mar 21, 2025
marcoandredinis
approved these changes
Mar 21, 2025
public-teleport-github-review-bot
bot
removed request for
Joerger,
r0mant and
zmb3
hugoShaka
force-pushed
the
hugo/buddy-52712-helm-sso
branch
from
1bfae17 to
9201aa8
Compare
Contributor
Author
|
Not sure why the doc preview fails, the build log is not very helpful. I rebased to see if someone already fixed it on master. |
Contributor
|
@hugoShaka See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buddy PR for #52712
This PR allows users to configure
second_factors(different fromsecond_factor). Sadlysecond_factorcannot always be translated tosecond_factors, so we have to keep both 🫠 .The chart now uses
secondFactorsby default. I deprecatedsecondFactorand might remove references to the value in the future. IfsecondFactoris set, it still takes precedence oversecondFactorsto ensure backward compatibility.Changelog: Helm chart now supports specifying a second factor list, this simplifies setting up SSO MFA with the
teleport-clusterchart.