[v17] Hide validation errors on newly added sections#53530
Merged
bl-nero merged 2 commits intobranch/v17from Apr 2, 2025
Merged
[v17] Hide validation errors on newly added sections#53530bl-nero merged 2 commits intobranch/v17from
bl-nero merged 2 commits intobranch/v17from
Conversation
* Add ValidationSuspender component This component makes it possible to conditionally hide validation errors in a subset of form fields. It is required by an upcoming PR to the role editor that satisfies the UX requirement of not showing validation errors on newly added sections until the next explicit validation is requested. Also: add type information to useRule. * Hide validation errors on newly added sections Uses ValidationSuspender to hold validation errors from being displayed on fields that belong to sections added while the validator is validating. The newly invalid inputs will be marked as invalid only after another explicit validation call (for example, when the user attempts to save data). * Post-merge test fix
bl-nero
added
the
no-changelog
avatus
approved these changes
Apr 1, 2025
tigrato
approved these changes
Apr 2, 2025
public-teleport-github-review-bot
bot
removed the request for review
from rudream
Contributor
Author
|
Retested on existing and new roles. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #53224 to branch/v17