Add RoleEditorVisualizer to Role Editor#53535
Merged
Conversation
avatus
added
the
no-changelog
bl-nero
reviewed
Mar 31, 2025
Contributor
bl-nero
left a comment
bl-nero
left a comment
There was a problem hiding this comment.
A couple of issues:
- Can you attach some screenshots?
- I think something is broken, since after checking this and the corresponding Enterprise branches, I'm unable to view Access Graph on my setup, while I can do it on my master branch. I'd like to understand whether my setup doesn't reflect the reality, or if there's some valid corner case that slipped through here.
web/packages/teleport/src/Roles/RoleEditor/RoleEditorAdapter.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Roles/RoleEditor/RoleEditorAdapter.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Roles/RoleEditor/RoleEditorAdapter.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Did you checkout the backend changes and build/run with those too? |
Contributor
Author
ill double check some corner cases. im guessing your setup has policy enabled (via license and config file) so you should have it "just work", and if not, then yeah something is borked! ill inspect today, appreciate it 🙏 |
avatus
force-pushed
the
avatus/access_graph_demo_frontend
branch
from
9aae8e1 to
b47ef2c
Compare
avatus
force-pushed
the
avatus/access_graph_demo
branch
from
aa6ec7c to
b923804
Compare
avatus
force-pushed
the
avatus/access_graph_demo_frontend
branch
from
b47ef2c to
da10ab5
Compare
avatus
changed the title
Contributor
Author
|
friendly ping when available @ryanclark @bl-nero |
bl-nero
approved these changes
Apr 1, 2025
Contributor
|
(For the record: it turned out that I had an incorrect branch checked out on |
ryanclark
approved these changes
Apr 2, 2025
avatus
added a commit
that referenced
this pull request
Apr 24, 2025
avatus
added a commit
that referenced
this pull request
Apr 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
* Add DemoMode and Status to AccessGraphSettings * Add RoleEditorVisualizer to Role Editor (#53535) * Allow cloud to update access graph settings (#53800) * Move demo mode check to RoleEditor (#53961) * Add optional chaining to demo mode check in RoleEditor (#53969) * Update proxy AccessGraphSettings permissions (#54009) This allows proxy to Read AccessGraphSettings, as well as prevents the "Preview Identity Security" button from showing up if the user does not have access to update access graph settings * Add AccessGraphDemoMode entitlement * Add DemoMode entitlement to Identity Security Preview button (#54300) This adds one extra conditional to display the access graph demo button. The user must also have the entitlement enabled. This is already checked when enabling demo mode in the backend, but with this frontend check we will hide the button if the request was going to fail anyway.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
* Add DemoMode and Status to AccessGraphSettings * Add RoleEditorVisualizer to Role Editor (#53535) * Allow cloud to update access graph settings (#53800) * Move demo mode check to RoleEditor (#53961) * Add optional chaining to demo mode check in RoleEditor (#53969) * Update proxy AccessGraphSettings permissions (#54009) This allows proxy to Read AccessGraphSettings, as well as prevents the "Preview Identity Security" button from showing up if the user does not have access to update access graph settings * Add AccessGraphDemoMode entitlement * Add DemoMode entitlement to Identity Security Preview button (#54300) This adds one extra conditional to display the access graph demo button. The user must also have the entitlement enabled. This is already checked when enabling demo mode in the backend, but with this frontend check we will hide the button if the request was going to fail anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component is used to contain and display the state of the role diff visualizer to include demo mode. Its either a policy placehodler (with the preview button), in a state of creating the graph (when enabling demo mode), or the role diff visualizer (with optional demo mode banner).
the hook (in the
epart of this PR) is kinda complex but rather than throwing around 4 differentattempts, i decided to amalgamate all of them into aRoleDiffStateenum. because really, it can only be in one state at once determined by the combinatorics of the attempts.requires #53371 and https://github.com/gravitational/teleport.e/pull/6231