Add health check config gRPC service#53554
Merged
GavinFrazar merged 1 commit intomasterfrom Apr 8, 2025
Merged
Conversation
GavinFrazar
added
no-changelog
GavinFrazar
force-pushed
the
gavinfrazar/db-healthchecks-5
branch
from
153179d to
7347869
Compare
GavinFrazar
force-pushed
the
gavinfrazar/db-healthchecks-6
branch
from
e6ea547 to
232312d
Compare
GavinFrazar
force-pushed
the
gavinfrazar/db-healthchecks-5
branch
from
7347869 to
28b87a3
Compare
GavinFrazar
force-pushed
the
gavinfrazar/db-healthchecks-6
branch
from
232312d to
599297c
Compare
greedy52
reviewed
Mar 29, 2025
Contributor
greedy52
left a comment
greedy52
left a comment
There was a problem hiding this comment.
LGTM. just one question on whether health check should be considered as an admin action:
https://goteleport.com/docs/admin-guides/access-controls/guides/mfa-for-admin-actions/
GavinFrazar
force-pushed
the
gavinfrazar/db-healthchecks-6
branch
3 times, most recently
from
789ec53 to
fbc4df3
Compare
Contributor
Author
I think that's a good idea, even though we didn't put that in the RFD draft. Added for Create, Update, Upsert, Delete. |
greedy52
approved these changes
Mar 31, 2025
GavinFrazar
force-pushed
the
gavinfrazar/db-healthchecks-6
branch
from
fbc4df3 to
8148040
Compare
Contributor
Author
|
@r0mant PTAL when you get a chance (most of the line diff is from tests btw) |
r0mant
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of another PR and will switch to master automatically when it merges:
Related issue: