MWI: Spike running the AWS RA service when auth server unavailable #55070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a spike of a possible solution for #53711.
How it works
Rather than depending on
*authclient.Clientorclient.Clientdirectly, we now pass around our own wrapper struct. If the bot identity service initialization fails but there is an old identity on-disk, it'll return "successfully" but the client wrapper will be rigged to return an error on each RPC.This effectively allows
tbotto run in a "degraded" state without a functioning API client, while the bot identity service'sRunmethod retries the initialization in the background.The roles anywhere service now writes its SVID to a "cache" destination (in-memory by default, but can be configured to on-disk) and if the client returns an error because initialization fails, it'll fall back to using the cached SVID for the exchange.
I've tested this manually by running
tbotonce with the following configuration, killing it, stopping the auth server, restartingtbot, and then restarting the auth server.