Fix key for headless OpDelete event
#55265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
approved these changes
May 29, 2025
Joerger
force-pushed
the
joerger/fix-headless-op-delete
branch
from
f028d73 to
8c211a0
Compare
zmb3
approved these changes
May 29, 2025
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Is there a test we can write that would have caught this bug?
Contributor
Author
I tried to squeeze in a test but didn't find a good way to to do so quickly. |
Joerger
added
the
no-changelog
Contributor
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in #46701 due to headless keys having an additional
/user/{user_id}prefix.Closes #48569