Add Resources stream to generic storage services
#55291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the generic.Service and generic.ServiceWrapper have a new `Resources(ctx context.Context, startKey, endKey string) iter.Seq2[Resource, error]` received method to allow iterating through a range of items stored. Their respective ListResources methods have been updated to use the backend.Items iteration instead of GetRange as well. This can be utilized by higher layers which want a way to effectively paginate and filter items. For the moment, it is only consumed outside of tests by `(PluginStaticCredentialsService) GetPluginStaticCredentialsByLabels` but was specifically added to be consumed by some of the scoped resource APIs in the near future.
rosstimothy
added
the
no-changelog
probakowski
approved these changes
Jun 16, 2025
atburke
approved these changes
Jun 16, 2025
bl-nero
pushed a commit
that referenced
this pull request
Aug 1, 2025
Both the generic.Service and generic.ServiceWrapper have a new `Resources(ctx context.Context, startKey, endKey string) iter.Seq2[Resource, error]` received method to allow iterating through a range of items stored. Their respective ListResources methods have been updated to use the backend.Items iteration instead of GetRange as well. This can be utilized by higher layers which want a way to effectively paginate and filter items. For the moment, it is only consumed outside of tests by `(PluginStaticCredentialsService) GetPluginStaticCredentialsByLabels` but was specifically added to be consumed by some of the scoped resource APIs in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the generic.Service and generic.ServiceWrapper have a new
Resources(ctx context.Context, startKey, endKey string) iter.Seq2[Resource, error]received method to allow iterating through a range of items stored. Their respective ListResources methods have been updated to use the backend.Items iteration instead of GetRange as well.This can be utilized by higher layers which want a way to effectively paginate and filter items. For the moment, it is only consumed outside of tests by
(PluginStaticCredentialsService) GetPluginStaticCredentialsByLabelsbut was specifically added to be consumed by some of the scoped resource APIs in the near future.