fix(comments): redraw comments on zoom/unzoom for non-highstock charts#857
Merged
fix(comments): redraw comments on zoom/unzoom for non-highstock charts#857
Conversation
Contributor
Coverage Report
File CoverageNo changed files found. |
Contributor
|
🎭 Tests Report is ready. |
Contributor
|
Preview is ready. |
korvin89
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual comments on non-highstock charts were not redrawn after zoom/unzoom. This caused comments outside the zoomed range to disappear permanently if the user toggled a legend item while zoomed in:
hideComments+drawCommentsran with the zoomed extremes (marking out-of-range comments asisFit = false), and when zooming out there was nothing to restore them.