Skip to content

feat: add position to the legend configuration (top and bottom options) #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2025
Merged

feat: add position to the legend configuration (top and bottom options) #263

merged 3 commits into from
Nov 18, 2025

Conversation

@arteria32
Copy link
Contributor

@arteria32 arteria32 commented Nov 15, 2025

No description provided.

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Nov 15, 2025

Preview is ready.

@gravity-ui
Copy link

gravity-ui bot commented Nov 15, 2025

Visual Tests Report is ready.

@arteria32
Copy link
Contributor Author

arteria32 commented Nov 17, 2025

@korvin89 @kuzmadom
Hi, implement the first step - adding a bottom and a top option for the legend position.

@arteria32 arteria32 marked this pull request as ready for review November 17, 2025 06:50
@arteria32 arteria32 mentioned this pull request Nov 17, 2025
Closed
kuzmadom
kuzmadom reviewed Nov 17, 2025
View reviewed changes
src/types/chart/legend.ts Outdated
/**
* The position of the legend box within the chart area.
*
* @experimental Can be changed in the future.
Copy link
Collaborator

@kuzmadom kuzmadom Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the tag is needed here? It looks stable enough to use without it. Additional changes in the future, such as adding left and right positioning, do not affect the stability of the API interface.

@kuzmadom
Copy link
Collaborator

kuzmadom commented Nov 17, 2025 •
edited
Loading

@arteria32 thanks for the pr — it looks great!
Could you add some screenshot tests before we merge?

  • basic case with legend.position = "top"
  • (nice to have) legend.html = true and a paginated legend
    These tests will help us catch any unintended visual changes in future updates.

@arteria32
Copy link
Contributor Author

arteria32 commented Nov 18, 2025

@arteria32 thanks for the pr — it looks great! Could you add some screenshot tests before we merge?

  • basic case with legend.position = "top"
  • (nice to have) legend.html = true and a paginated legend
    These tests will help us catch any unintended visual changes in future updates.

done

@kuzmadom kuzmadom changed the title [wip] feat (Legend): add position to the legend configuration (top and bottom options) feat: add position to the legend configuration (top and bottom options) Nov 18, 2025
@arteria32 arteria32 merged commit e421cf5 into gravity-ui:main Nov 18, 2025
5 checks passed
@gravity-ui-bot gravity-ui-bot mentioned this pull request Nov 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuzmadom kuzmadom kuzmadom approved these changes

@korvin89 korvin89 Awaiting requested review from korvin89 korvin89 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arteria32 @gravity-ui-bot @kuzmadom @ARTer1a