feat: update linting plugins, jest and storybook#84
Merged
KirillDyachkovskiy merged 5 commits intomainfrom Aug 1, 2023
Merged
Conversation
KirillDyachkovskiy
requested review from
DarkGenius,
Marginy605,
NikitaCG,
ValeraS,
amje,
korvin89,
niktverd and
ogonkov
as code owners
added 2 commits
July 31, 2023 12:05
Contributor
|
Preview is ready. |
Marginy605
approved these changes
Jul 31, 2023
KirillDyachkovskiy
changed the title
korvin89
requested changes
Jul 31, 2023
Contributor
korvin89
left a comment
korvin89
left a comment
There was a problem hiding this comment.
We have our own rules here https://github.com/gravity-ui/eslint-config
NikitaCG
requested changes
Jul 31, 2023
| "jest": true | ||
| }, | ||
| "rules": { | ||
| "import/order": [ |
Contributor
There was a problem hiding this comment.
Don't you want to add it here https://github.com/gravity-ui/eslint-config ? If someone wants to set the same rules for themselves, then they just import them into their project
korvin89
approved these changes
Aug 1, 2023
NikitaCG
approved these changes
Aug 1, 2023
Ruminat
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.