feat(RelativeRangeDatePicker): remove dates hint #75
Conversation
|
Preview is ready. |
|
@ValeraS I suggest to remove it for now due to it buggy behaviour. What do you think about it? |
| /** A placeholder date that controls the default values of each segment when the user first interacts with them. Defaults to today's date at midnight. */ | ||
| placeholderValue?: DateTime; | ||
| /** Show dates hint on calendar button hover **/ | ||
| withDatesHint?: boolean; |
There was a problem hiding this comment.
I think, the prop should hide the hint for better backward compatibility and it name should be "hideDatesHint".
And if we specify property "hideDatesHint" in the component, then the hint will be hidden, if not, or it is false, then the hint will be shown. Such behaviour is more logical for me
There was a problem hiding this comment.
The thing is the component accepts all the boolean properties with show prefix
Also, by default the hint will be shown, this guarantees backward compatibility, because the condition is withDatesHint !== false, not withDatesHint
There was a problem hiding this comment.
But yes, hideDatesHint looks more logical.
kseniya57
force-pushed
the
make-hint-optional
branch
from
985b5db to
7b7c297
Compare
kseniya57
changed the title
Closes #74