Skip to content

fix: one of view #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NasgulNexus merged 2 commits into from
Dec 29, 2023
Merged

fix: one of view #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
791f70a
fix: one of view
NasgulNexus Dec 29, 2023
d0c9fe2
fix: text link, card one of, multi one of view
NasgulNexus Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/kit/components/Views/CardOneOfView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ export const CardOneOfView: ObjectIndependentView = (props) => {
{specProperties[valueKey] ? (
<ViewController
spec={specProperties[valueKey]}
name={`${name}.${valueKey}`}
key={`${name}.${valueKey}`}
name={`${name ? name + '.' : ''}${valueKey}`}
key={`${name ? name + '.' : ''}${valueKey}`}
/>
) : null}
</Card>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/kit/components/Views/MultiOneOfView/MultiOneOfView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const MultiOneOfView: React.FC<MultiOneOfViewProps> = (props) => {
<React.Fragment key={value}>
{specProperties && specProperties[value] ? (
<ViewController
name={`${name}.${value}`}
name={`${name ? name + '.' : ''}${value}`}
spec={specProperties[value]}
/>
) : null}
Expand Down
4 changes: 2 additions & 2 deletions src/lib/kit/components/Views/OneOfView/OneOfView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ const OneOfViewComponent: React.FC<OneOfViewProps> = (props) => {
<GroupIndent>
<ViewController
spec={specProperties[valueKey]}
name={`${name}.${valueKey}`}
key={`${name}.${valueKey}`}
name={`${name ? name + '.' : ''}${valueKey}`}
key={`${name ? name + '.' : ''}${valueKey}`}
/>
</GroupIndent>
) : null}
Expand Down
7 changes: 6 additions & 1 deletion src/lib/kit/components/Views/TextLinkView/TextLinkView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ export const TextLinkView: ObjectIndependentView = ({value, spec, name, Layout,
return null;
}

const content = <ViewController spec={childSpec} name={`${name}.${TEXT_LINK_PROPERTY_NAME}`} />;
const content = (
<ViewController
spec={childSpec}
name={`${name ? name + '.' : ''}${TEXT_LINK_PROPERTY_NAME}`}
/>
);

if (Layout) {
return (
Expand Down