feat(GraphComponent, HitBox): introduce interactive and non-boundary components #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
draedful
changed the title
draedful
changed the title
Antamansid
reviewed
Aug 30, 2025
src/services/HitTest.ts
Outdated
| if (item.affectsUsableRect) { | ||
| if (this.usableRectTracker.has(item)) { | ||
| this.usableRectTracker.update(item, bbox); | ||
| item.updateRect(bbox); |
Collaborator
There was a problem hiding this comment.
I thinkupdateRect can be deleted from 104 and 106 row, anyway, it's already being done on 112 row. Now, as I understand, updateRect happens twice.
Antamansid
approved these changes
Sep 1, 2025
| () => { | ||
| const items = []; | ||
| const interactiveItems = []; | ||
|
|
Collaborator
There was a problem hiding this comment.
You should here check like:
let shouldUpdateUsableRect = falseand here on 102 line:
if (item.affectsUsableRect) {
shouldUpdateUsableRect = true
...this is because this.updateUsableRect always returns a new object, which causes the positions of the blocks whose positions depend on usabelRect to change.
Or deepEqual updateUsableRect value always before update it
Interactive components are components that can be interacted with. (GraphComponent props {interactive: true})
Non-boundary components are components that are not affected by the usable rect. (GraphComponent props {affectsUsableRect: false})
Non-boundary components are useful when you need to position component outside of the usable rect.
draedful
force-pushed
the
hitbox-usable-rect-fix
branch
from
96c83dc to
9609fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactive components are components that can be interacted with. (GraphComponent props {interactive: true})
Non-boundary components are components that are not affected by the usable rect. (GraphComponent props {affectsUsableRect: false})
Non-boundary components are useful when you need to position component outside of the usable rect.