refactor(Camera): add setting to override default scale resolver#274
Merged
refactor(Camera): add setting to override default scale resolver#274
Conversation
Contributor
|
Preview is ready. |
SimbiozizV
reviewed
Mar 24, 2026
SimbiozizV
approved these changes
Mar 24, 2026
draedful
force-pushed
the
camera_scale_resolver
branch
from
0e2287d to
d40e871
Compare
Antamansid
approved these changes
Mar 24, 2026
Collaborator
Antamansid
left a comment
Antamansid
left a comment
There was a problem hiding this comment.
I never got around to it.
Sorry!!!
|
|
||
| public setupSettings(config: Partial<TGraphSettingsConfig>) { | ||
| this.$settings.value = Object.assign({}, this.$settings.value, config); | ||
| const merged = Object.assign({}, this.$settings.value, config); |
Collaborator
There was a problem hiding this comment.
Maybe something like this?
this.$settings.value = Object.assign({}, this.$settings.value, config);
if (!this.$settings.value.getCameraBlockScaleLevel) {
this.$settings.value.getCameraBlockScaleLevel = defaultGetCameraBlockScaleLevel;
}
…ectly and enhance documentation
draedful
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.