Skip to content

fix(Groups): prevent stale state from overwriting group drag position #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
draedful merged 1 commit into from
Apr 25, 2026
+4 −1
Merged

fix(Groups): prevent stale state from overwriting group drag position #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/canvas/groups/Group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,12 @@ export class Group<T extends TGroup = TGroup> extends GraphComponent<TGroupProps
if (this.isDragging) {
// Suppress rect update during drag to prevent the block bounding-box signal chain
// from overwriting the position set by handleDrag / subclass snapping logic.
// Use getState() instead of this.state to get the pending nextState (which includes
// the rect set by handleDrag in the same frame), preventing it from being overwritten
// with the stale this.state.rect.
const { rect: _rect, ...groupWithoutRect } = group;
this.setState({
...this.state,
...this.getState(),
...groupWithoutRect,
} as T);
} else {
Expand Down
Loading